Prevent renewal subscription orders from being created if subscription was made in the mode that doesn't match current WooPayments mode #10606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
…ption-mode-does-not-match-current-mode
…ption-mode-does-not-match-current-mode
RadoslavGeorgiev
approved these changes
Mar 25, 2025
includes/subscriptions/class-wc-payments-subscription-service.php
Outdated
Show resolved
Hide resolved
RadoslavGeorgiev
added
pr: ready to merge
pr: needs author reply
and removed
pr: needs review
labels
|
|
dmvrtx
deleted the
add/3687-prevent-renewal-order-if-subscription-mode-does-not-match-current-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3687
Changes proposed in this Pull Request
Add a hook to the
wcs_renewal_order_itemsfilter to stop the renewal order from being created if WooPayments is now in the mode that doesn't match the original subscription mode. E.g. if original subscription was paid in the test mode and WooPayments is now in the live mode.wcs_renewal_order_itemsis called within a transaction when renewal order is being constructed. Therefore, an error here will result in the order not being created and an error message reported.Testing instructions
_wcpay_modemeta for the created order in the database tablewp_wc_orders_meta. E.g. to "foo".Creation of the pending renewal order failed. The subscription was made in the mode "foo" that does not match the current WooPayments mode "test".WooCommerce -> Status -> Scheduled actionswoocommerce_scheduled_subscription_paymentwith the subscription order.Note
When Shopper tries to renew a subscription themselves it appears to go into the different flow and creates a new order in the correct WooPayments mode and is unaffected by this change.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge