Skip to content

set merges deeply nested objects #14870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

set merges deeply nested objects #14870

merged 1 commit into from
Sep 9, 2024
+33 −1

Conversation

ianHeydoc
Copy link
Contributor

Summary
solves the issue of deeply nested documents not merging when merge option is set

Examples

Example is in the test

@vkarpov15 vkarpov15 added this to the 8.6.2 milestone Sep 9, 2024
vkarpov15
vkarpov15 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 merged commit d533e9f into Automattic:master Sep 9, 2024
23 of 24 checks passed
@ianHeydoc
Copy link
Contributor Author

Thanks!
Will this fix also work on versions 6 and 7 of mongoose?
Or should I write PRs for those branches as well

@vkarpov15 vkarpov15 mentioned this pull request Sep 9, 2024
Closed
2 tasks
vkarpov15 added a commit that referenced this pull request Sep 10, 2024
@vkarpov15
fix: backport #14870 to 6.x
9178805
@vkarpov15
Copy link
Collaborator

@ianHeydoc I put in PR #14878 to backport this to 6.x, that will also end up in 7.x.

@hasezoey hasezoey mentioned this pull request Sep 11, 2024
Merged
vkarpov15 added a commit that referenced this pull request Sep 11, 2024
@vkarpov15
Merge pull request #14878 from Automattic/vkarpov15/gh-14861
abedf3c 
fix: backport #14870 to 6.x
This was referenced Oct 3, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@akanchhaS akanchhaS mentioned this pull request Oct 3, 2024
Open
@Domin737 Domin737 mentioned this pull request Oct 3, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Oct 3, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 3, 2024
Open
@lholmquist lholmquist mentioned this pull request Oct 3, 2024
Merged
@issam-seghir issam-seghir mentioned this pull request Oct 3, 2024
Open
@nfgallimore nfgallimore mentioned this pull request Oct 3, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
@AmarBego AmarBego mentioned this pull request Oct 3, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Oct 3, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 3, 2024
Open
@arenault-pass arenault-pass mentioned this pull request Oct 3, 2024
Closed
@ASHOKECE1999 ASHOKECE1999 mentioned this pull request Oct 10, 2024
Open
@ValeriaTapiaG ValeriaTapiaG mentioned this pull request Oct 12, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 13, 2024
Open
@DulranS DulranS mentioned this pull request Oct 14, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 16, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Oct 20, 2024
Open
@ShivamNimje6 ShivamNimje6 mentioned this pull request Oct 20, 2024
Open
@zntb zntb mentioned this pull request Oct 21, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Oct 22, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 23, 2024
Open
@DulranS DulranS mentioned this pull request Oct 23, 2024
Open
@Tobsukka Tobsukka mentioned this pull request Oct 25, 2024
Open
@ranjith221132 ranjith221132 mentioned this pull request Oct 25, 2024
Open
@k2xl k2xl mentioned this pull request Oct 25, 2024
Closed
@hamzabetbaieb hamzabetbaieb mentioned this pull request Oct 25, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Oct 25, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 25, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Oct 26, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Oct 27, 2024
Open
@DulranS DulranS mentioned this pull request Oct 27, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Oct 28, 2024
Open
@Manojgupta103 Manojgupta103 mentioned this pull request Oct 28, 2024
Merged
@xeni09 xeni09 mentioned this pull request Oct 28, 2024
Open
@DulranS DulranS mentioned this pull request Oct 28, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Oct 30, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Oct 30, 2024
Open
@DulranS DulranS mentioned this pull request Oct 31, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Oct 31, 2024
Open
@Niaz-estefaie Niaz-estefaie mentioned this pull request Oct 31, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ianHeydoc @vkarpov15