-
-
Couldn't load subscription status.
- Fork 1.3k
Simplify release workflow #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
With #2678, the release draft can be created in one request, rather than generating the notes and then manually editing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR simplifies the GitHub release workflow by leveraging the native generate_release_notes feature instead of manually generating and filtering release notes. The change reduces code complexity by removing manual note generation and filtering logic.
- Replaces manual release note generation with GitHub's built-in
generate_release_notesparameter - Moves bot exclusion logic from JavaScript filtering to the
.github/release.ymlconfiguration file - Reduces the workflow code by eliminating intermediate variables and filtering operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Removes manual release note generation and filtering, uses generate_release_notes: true parameter |
.github/release.yml |
Adds github-actions[bot] to the excluded authors list for automatic release note generation |
Fix wrong variable name.
Remove undefined and now unused variable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7322 7322
Branches 1012 1012
=======================================
Hits 7046 7046
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
With #2678, the release draft can be created in one request, rather than generating the notes and then manually editing them first.