-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Not privileged setrate [POSTREFORMAT] #10520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Not privileged setrate [POSTREFORMAT] #10520
Conversation
There's one issue I forgot about: IPT is not saved for standard logic processors. If it were saved, it might cause issues if the default IPT changes, and users load an old save. |
fixed saving with check for saving with max ipt: and don't worry, I did a version check |
revision 4 is mine :3 anyways, the saving seems overcomplicated, and looks like it might run into integer overflow issues due to saving as short, but using an int. |
i would just do |
either of us will increment if the other gets merged 1st :)
I simply mirrored the world processor ipt saving, I'd think that integer overflow would happen to both |
ensures that if a processor were to get nerfed, no processor remains higher than normal |
huh |
welp, i would just make it save as an integer with clamping then ig |
hm? |
hello? |
? |
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
reposted as permitted, modified to be compatible with the refactor