This repository was archived by the owner on Oct 18, 2024. It is now read-only.
fix: set expanded state by default in BaseBottomSheetFragment #1903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @teixeira0x, can you clarify a bit more about this issue? Is this related to an existing issue? If not, can you provide the before/after effects of these changes? |
Contributor
Author
sure, here are screenshots of how this should affect BottomSheet's behavior How the BottomSheet looked before: After: On my device this change only affects when the screen is in landscape orientation. |
itsaky
approved these changes
Sep 10, 2024
Member
|
Thanks for the clarification. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of BottomSheet not appearing in full when the screen is lying down