Skip to content

Conversation

@anyzelman
Copy link
Member

@anyzelman anyzelman commented Apr 7, 2025

Closes issue #352 .

@anyzelman anyzelman linked an issue Apr 7, 2025 that may be closed by this pull request
@anyzelman
Copy link
Member Author

At this point all unit tests and smoke tests pass

@anyzelman
Copy link
Member Author

At this point also all unit & smoke tests are OK

@anyzelman
Copy link
Member Author

anyzelman commented Apr 17, 2025

At this point, all smoke and unit tests pass. Also using OSP's simulator, the sptrsv code introduced here is thoroughly verified, for all three sorting modes.

Some next items remain:

  • adapt build infra to take OSP as an optional module;
  • spec out a tune step (suggest introducing grb::PHASE::TUNE);
  • when OSP is enabled, allow the sptrsv tuning step to call OSP;
  • optionally (or alternatively) allow reading-in OSP schedules from some external source;
  • expose a transition path for the unmasked sptrsv with dense input/output vectors;
  • create a performance test driver for (tuned) sptrsv with dense input/output vectors;
  • implement and unit-test combinations of masked sptrsv and sptrsv with sparse I/O vectors;
  • relatedly, expand the current-quite-basic unit test for the unmasked sptrsv with dense I/O vectors - ideally use a golden output from an external software package like Octave on a small (e.g. 550x550) synthetic system.

No specific milestone will be set for this new feature, but please raise it if this functionality is urgent and we can attempt take that into account. This MR will not address the triangular type structure from Spampinato et al.- ideally first the dense backend (with dense trsv support) is merged after which a new MR can enable sptrsv support through the functionalities provided by this MR.

@anyzelman
Copy link
Member Author

Target set to v0.9

@anyzelman anyzelman added this to the v0.9 milestone Oct 17, 2025
@anyzelman anyzelman added the enhancement New feature or request label Oct 17, 2025
@anyzelman anyzelman self-assigned this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce a NUMA-aware sptrsv

3 participants