Enable multiplexing for Storage Write API Default Stream #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrawal-siddharth
approved these changes
Aug 24, 2025
Claudenw
requested changes
Aug 28, 2025
| /** | ||
| * Override to provide additional configs to JsonStreamWriter | ||
| */ | ||
| protected void applyJsonWriterConfig(JsonStreamWriter.Builder builder) { |
There was a problem hiding this comment.
Please change this to updateJsonStreamWriterBuilder or something similar that indicates that this class is updating the argument.
The current name makes it sound like we are using the builder to apply a config to this object.
There was a problem hiding this comment.
Updated. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enables multiplexing for the Storage Write API.
Note: multiplexing is only available when using the default stream.
What this does