Conditionally harden methods #184
Merged
+131
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method hardening is enabled by default to discourage dangerous undocumented method misuse. To disable method hardening, set the harden configuration option to false in Ruby or using the AIKIDO_HARDEN environment variable.
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
The fallback solution could be optimized by limiting the special case to array query parameters. Should this be done? |
hansott
reviewed
Oct 29, 2025
hansott
approved these changes
Oct 29, 2025
|
Optimization was discussed internally and the decision was made not to optimize this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method hardening is enabled by default, to discourage dangerous undocumented method misuse i.e. calling
File.joinwith possibly nested arrays (see #168 for a discussion of method hardening forFile.join; the only hardened method currently implemented.)This change allows method hardening to be disabled globally, by setting the
hardenconfiguration option to false in Ruby or by using theAIKIDO_HARDENenvironment variable. Method hardening should only be disabled if the detected misuse is not immediately correctable.If method hardening is disabled, in order to reliably detect path traversal attacks in
File.join, all arrays in user input must be treated as potential paths, joined and stored in the context, at a potentially significant cost. (See #155 for a discussion of this fallback to fixFile.joinpath traversal bypasses).