Fix auto demotion action #201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues in the admin-support-cli related to GitHub Action workflow execution and issue parsing. The main goal is to ensure that workflows can run independently without breaking when no issue is present, and to correctly parse issue properties with proper case sensitivity.
- Moves issue validation from global scope to specific actions that require issues
- Fixes case-sensitive property parsing for issue duration field
- Adds error handling guard for GitHub issue comment creation
Reviewed Changes
Copilot reviewed 3 out of 16 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| admin-support-cli/src/main.ts | Relocates issue validation to action-specific cases and adds error handling guard |
| admin-support-cli/src/commands/actions/check-auto-demotion-action.ts | Corrects property name from lowercase to capitalized Duration |
| admin-support-cli/tests/commands/actions/check-auto-demotion-action.test.ts | Updates test mock to match corrected property name |
|
This PR is in response to this issue; #200 |
|
Ping @ActionsDesk/services-delivery |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues in the admin-support-cli.
Ran
npm run allbefore creating the PR to ensure the linter and tests works as expected