configure/build: Support user-specified application configuration #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 92 92
Lines 2779 2781 +2
=======================================
+ Hits 2698 2700 +2
Misses 81 81
|
LDong-Arm
commented
Jun 22, 2021
Contributor
Author
|
The Travis failure has nothing to do with this PR or mbed-tools. I've created a fix for it: ARMmbed/mbed-os#14829 Update: See ARMmbed/mbed-os#14829 (comment). The proper fix would be migrating K64F from ARDUINO form factor to ARDUINO_UNO form factor. The main issue to track Pin Names migration of all targets is ARMmbed/mbed-os#14484. Alternatively, we can use a different target in Travis for the time being. |
Patater
suggested changes
Jun 25, 2021
This commit removes the default arguments of the `build()` function to rely on click to provide default values. As for `--toolchain` and `--mbed-targets` which must be provided by the user, we enable `required=True` to let click check them for us. This is consistent with how arguments are checked for the `configure()` function. Despite the main benefit of taking advantage of click's built-in check, a slight drawback is that click only checks one argument at a time, instead of asking the user to specify both toolchain and mbed-target. But this is okay because the user needs to pass both in order to not get any errors eventually. The test case where both target and toolchain options are missing has been removed accordingly. The existing tests for one missing option (one for toolchain, one for target) are sufficient.
Add an option `--app-config` to `configure` and `compile`, to allow users to specify an application configuration file. If unspecified, mbed-tools will use `mbed_app.json` if the latter exists. Tests are provided. Fixes ARMmbed#291
Contributor
Author
|
Rebased and updated commit message |
Patater
approved these changes
Jun 25, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option
--app-configtoconfigureandcompile, to allow users to specify an application configuration file. If unspecified, mbed-tools will usembed_app.jsonif the latter exists.Tests are provided.
Fixes #291
Also: Remove default arguments of
build()that duplicate what we set with click.Test Coverage