Skip to content

Fixed bugs in Fast Model MPS2 GCC startup scripts #8648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2018
Merged

Fixed bugs in Fast Model MPS2 GCC startup scripts #8648

merged 2 commits into from
Nov 9, 2018

Conversation

@jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented Nov 5, 2018

Description

In Fast Models MPS2 targets (M3/M4/M7), the GCC startup scripts defined external interrupt handlers were wrong.

Now got them fixed. They are aligned with ARMCC and IAR toolchain startup scripts

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ARMmbed/mbed-os-hal

@jamesbeyond
Copy link
Contributor Author

jamesbeyond commented Nov 5, 2018

GreenTea test results for gcc attached

mbedgt: test suite report:
+---------------------+---------------+------------------------------------------------------------------------------+--------+--------------------+-------------+
| target              | platform_name | test suite                                                                   | result | elapsed_time (sec) | copy_method |
+---------------------+---------------+------------------------------------------------------------------------------+--------+--------------------+-------------+
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-device_key-tests-device_key-functionality                           | OK     | 8.61               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-basic_test                        | OK     | 7.86               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-basic_test_default                | OK     | 8.31               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-case_async_validate               | OK     | 7.9                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-case_control_async                | OK     | 7.99               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-case_control_repeat               | OK     | 9.07               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-case_selection                    | OK     | 7.47               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-case_setup_failure                | OK     | 7.58               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-case_teardown_failure             | OK     | 7.95               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-control_type                      | OK     | 8.53               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-minimal_async_scheduler           | OK     | 8.31               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-minimal_scheduler                 | OK     | 8.6                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-test_assertion_failure_test_setup | OK     | 9.95               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-test_setup_case_selection_failure | OK     | 7.86               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-test_setup_failure                | OK     | 7.98               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-frameworks-utest-tests-unit_tests-test_skip                         | OK     | 8.17               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-nvstore-tests-nvstore-functionality                         | OK     | 9.81               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-buffered_block_device                     | OK     | 9.37               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device                     | OK     | 7.84               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-general_block_device                      | OK     | 8.64               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-heap_block_device                         | OK     | 7.81               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-mbr_block_device                          | OK     | 7.6                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-util_block_device                         | OK     | 8.35               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-events-queue                                                           | OK     | 8.24               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-events-timing                                                          | OK     | 43.22              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-integration-basic                                                      | OK     | 7.86               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-c_strings                                                 | OK     | 8.03               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-crc                                                       | OK     | 8.46               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-dev_null                                                  | OK     | 9.88               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-echo                                                      | OK     | 18.83              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                                                  | OK     | 8.19               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-generic_tests                                             | OK     | 7.9                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-race_test                                                 | OK     | 7.66               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-stl_features                                              | OK     | 7.74               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-ticker                                                    | OK     | 10.46              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-timeout                                                   | OK     | 10.54              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-timer                                                     | OK     | 9.01               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-timerevent                                                | OK     | 10.48              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_functional-callback                                               | OK     | 7.54               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_functional-callback_big                                           | OK     | 7.81               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_functional-callback_small                                         | OK     | 10.59              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_functional-functionpointer                                        | OK     | 8.17               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-common_tickers                                                | OK     | 7.92               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-critical_section                                              | OK     | 9.49               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                                         | OK     | 8.11               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-minimum_requirements                                          | OK     | 8.37               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-rtc_time                                                      | OK     | 8.87               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-rtc_time_conv                                                 | OK     | 117.21             | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-ticker                                                        | OK     | 8.86               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-us_ticker                                                     | OK     | 7.78               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-circularbuffer                                           | OK     | 8.7                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-critical_section                                         | OK     | 8.28               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-error_handling                                           | OK     | 8.18               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-filehandle                                               | OK     | 8.04               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-sharedptr                                                | OK     | 8.03               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-singletonptr                                             | OK     | 7.53               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-stream                                                   | OK     | 7.8                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-system_reset                                             | OK     | 9.45               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_platform-transaction                                              | OK     | 7.5                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-mbed-attributes                                              | OK     | 7.87               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-mbed-call_before_main                                        | OK     | 7.49               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-mbed-cpp                                                     | OK     | 8.62               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-mbed-div                                                     | OK     | 7.47               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-mbed-static_assert                                           | OK     | 7.86               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-condition_variable                                 | OK     | 7.93               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-event_flags                                        | OK     | 12.62              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-heap_and_stack                                     | OK     | 8.5                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-kernel_tick_count                                  | OK     | 8.81               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-mail                                               | OK     | 7.95               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-malloc                                             | OK     | 28.36              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-memorypool                                         | OK     | 8.24               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-mutex                                              | OK     | 10.36              | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-queue                                              | OK     | 7.48               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-rtostimer                                          | OK     | 8.63               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-semaphore                                          | OK     | 8.8                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-signals                                            | OK     | 8.9                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedmicro-rtos-mbed-threads                                            | OK     | 8.13               | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedtls-multi                                                          | OK     | 8.0                | default     |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbedtls-selftest                                                       | OK     | 17.26              | default     |
+---------------------+---------------+------------------------------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 79 OK

0xc0170
0xc0170 approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one cosmetic request (for future reference)

...ets/TARGET_ARM_FM/TARGET_FVP_MPS2/TARGET_FVP_MPS2_M0/device/TOOLCHAIN_GCC_ARM/startup_MPS2.S Outdated
Copy link
Contributor

@0xc0170 0xc0170 Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic/coding changes should be separate commit

Copy link
Contributor Author

@jamesbeyond jamesbeyond Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, pushed a separate commit

@0xc0170 0xc0170 requested a review from a team November 6, 2018 08:50
@cmonr cmonr mentioned this pull request Nov 9, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

Note: This PR is now a part of a rollup PR (#8686).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr cmonr merged commit 97ac4bb into ARMmbed:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@donatieng donatieng donatieng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.10.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesbeyond @cmonr @0xc0170 @donatieng