-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix Makefile export with Python 3 #8577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Makefile export with Python 3 #8577
Conversation
In Python 3, the map() function returns a map object, not a list object as in Python 2. Ensure a list object is returned from format_flags() by wrapping map() in list(). This is compatible with both Python 2 and 3.
|
Thank you @lassebm for fix , we already assigned reviewers and will review it soon ! |
|
/morph build |
Build : SUCCESSBuild number : 3523 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3140 |
|
/morph mbed2-build |
Test : SUCCESSBuild number : 3307 |
|
@theotherjimmy , care to take a look? this really should only take a moment (tiny change) |
|
@NirSonnenschein Thanks for the ping. Feel free to merge this. |
Description
In Python 3, the
map()function returns amapobject, not alistobject as inPython 2. Ensure a
listobject is returned fromformat_flags()by wrappingmap()inlist(). This is compatible with both Python 2 and 3.Regression in c777bd6.
Pull request type