Skip to content

Conversation

@maclobdell
Copy link
Contributor

Description

K66F has an SD Card. Let's implement it as the default storage using the new default storage mechanism in 5.10. This helps ensure new example apps that use BlockDevice::get_default_instance(); work with no extra configuring.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

@mmahadevan108
Copy link
Contributor

Will this be using the SD card available via the Arduino connector (e.g ci-test shield)?

@maclobdell
Copy link
Contributor Author

@mmahadevan108 the K66F has an on-board micro SD card connector. so arduino shield is not necessary.

@geky geky requested review from a team, dannybenor and yossi2le October 11, 2018 03:44
@maclobdell
Copy link
Contributor Author

I updated the branch to remove the Feature: Storage, so the CFStore will not be added with this PR.

Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

Build : SUCCESS

Build number : 3418
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8348/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2018

@cmonr cmonr merged commit 353e8bd into ARMmbed:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants