Skip to content

Conversation

@theotherjimmy
Copy link
Contributor

Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

Resolves #7155
Tested on partnerbeta.
Includes minor formatting fixes that I found at the time as seperate
commits.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

### Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
Copy link
Contributor

@TomoYamanaka TomoYamanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We will make a final confirmation when this PR merged on Arm Mbed Online environment because we don't know the verifying method at this time.

@cmonr
Copy link
Contributor

cmonr commented Oct 10, 2018

This is such a strange flow.

This change doens't seem to be cooperating with a certain set of targets. Refer to these build logs: #8357 (comment)

@cmonr
Copy link
Contributor

cmonr commented Oct 17, 2018

/moprh build

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

/moprh build

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2018

Build : FAILURE

Build number : 3399
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8303/

@theotherjimmy
Copy link
Contributor Author

Should be fixed now @cmonr

@cmonr
Copy link
Contributor

cmonr commented Oct 19, 2018

Yay! Time to warm up the lab.
/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2018

Build : SUCCESS

Build number : 3406
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8303/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2018

@cmonr cmonr merged commit c004aa8 into ARMmbed:master Oct 19, 2018
@cmonr cmonr removed the needs: CI label Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error occurs when building exported mbed-os programs on e2studio

6 participants