Skip to content

tools, NRF51-post-build: Use paths to hex files #8275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2018
Merged

tools, NRF51-post-build: Use paths to hex files #8275

merged 1 commit into from
Oct 8, 2018

Conversation

@theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Sep 27, 2018

Description

The NRF51 post build hook finds it's hex files using the Resources
object. This PR fixes the corner case where the hex files within a
project have a name!=path (This really only happens online).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@theotherjimmy
tools, NRF51-post-build: Use paths to hex files
080c72b 
### Description

The NRF51 post build hook finds it's hex files using the Resources
object. This PR fixes the corner case where the hex files within a
project have a name!=path (This really only happens online).

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3243
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8275/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Test : SUCCESS

Build number : 3052
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8275/3052

@studavekar
Copy link
Contributor

studavekar commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2848
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8275/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2858
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8275/

@NirSonnenschein
Copy link
Contributor

NirSonnenschein commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : FAILURE

Build number : 2867
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8275/

@NirSonnenschein
Copy link
Contributor

NirSonnenschein commented Oct 6, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Exporter Build : SUCCESS

Build number : 2875
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8275/

@cmonr cmonr merged commit 5102610 into ARMmbed:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@cmonr cmonr cmonr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.10.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@theotherjimmy @0xc0170 @mbed-ci @studavekar @NirSonnenschein @cmonr