Skip to content

Tools, Resources: Convert to a set during win2unix #8248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

Tools, Resources: Convert to a set during win2unix #8248

merged 1 commit into from
Oct 11, 2018

Conversation

@theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Sep 25, 2018

Description

The exporters were failing as some things would end up as a list after
win2unix. Resolves #7954

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested review from bridadan and cmonr September 26, 2018 03:29
bridadan
bridadan approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line change 🎉 Looks good

This was referenced Oct 10, 2018
Closed
Closed
@NirSonnenschein
Copy link
Contributor

NirSonnenschein commented Oct 11, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Build : SUCCESS

Build number : 3321
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8248/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Exporter Build : FAILURE

Build number : 2956
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8248/

@cmonr
Copy link
Contributor

cmonr commented Oct 11, 2018

All licensing tokens for the specified feature are already in use. Status code 0xc8001006. [LicenseCheck:2.15.2.J2938, RMS:8.5.1.2009, Feature:ARM.EW.COMPILER, Version:1.10]

booo

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Exporter Build : SUCCESS

Build number : 2957
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8248/

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Test : SUCCESS

Build number : 3132
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8248/3132

@cmonr cmonr merged commit 19190d6 into ARMmbed:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@cmonr cmonr cmonr approved these changes

@bridadan bridadan bridadan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.10.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@theotherjimmy @NirSonnenschein @mbed-ci @cmonr @0xc0170 @bridadan