Skip to content

MIMXRT1050_EVK: Fix the GPIO IRQ number assignements #7420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

MIMXRT1050_EVK: Fix the GPIO IRQ number assignements #7420

merged 1 commit into from
Jul 5, 2018

Conversation

@mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented Jul 4, 2018

Description

MIMXRT1050_EVK: Fix the GPIO IRQ number assignements. Use the GPIO_Combined IRQ array.
This issue was uncovered when running ci-test shield tests. With this fix the GPIO Interrrupt tests passes.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mmahadevan108
MIMXRT1050_EVK: Fix the GPIO IRQ number assignements
9b48f39 
Use the GPIO_Combined IRQ array

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

mmahadevan108 commented Jul 4, 2018

cc @0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2531
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7420/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Exporter Build : SUCCESS

Build number : 2179
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7420/

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Test : SUCCESS

Build number : 2293
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7420/2293

cmonr
cmonr reviewed Jul 5, 2018
View reviewed changes
targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_IMX/gpio_irq_api.c
NVIC_SetVector(gpio_irqs[obj->port], vector);
NVIC_EnableIRQ(gpio_irqs[obj->port]);

int_index = 2 * obj->port;;
Copy link
Contributor

@cmonr cmonr Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ;; can be fixed in another PR since this is good to go.

Copy link
Contributor Author

@mmahadevan108 mmahadevan108 Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this, changed

@cmonr cmonr merged commit 9f27672 into ARMmbed:master Jul 5, 2018
@0xc0170 0xc0170 removed the needs: CI label Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@cmonr cmonr cmonr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.9.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmahadevan108 @0xc0170 @mbed-ci @cmonr