Skip to content

Conversation

@AnttiKauppila
Copy link

@AnttiKauppila AnttiKauppila commented Mar 5, 2018

Description

nsapi_socket_t errors fixed in unittests
No code changes done, so should be trivial merge

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@AnttiKauppila
Copy link
Author

@jarvte, @kjbracey-arm Can you review this

kjbracey
kjbracey previously approved these changes Mar 5, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2018

nsapi_socket_t errors fixed in unittests

Can you update your commit msg and describe the fix (the line here in quote is actually what can be there). A commit msg like "Cellular tests: fix socket errors" and paragraph above would describe a bit more if needed.

@AnttiKauppila
Copy link
Author

@0xc0170 Good suggestion Martin, this is now fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1335
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6268/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr cmonr added the needs: CI label Mar 5, 2018
@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

I like trivial changes.

@cmonr cmonr merged commit 772a857 into ARMmbed:master Mar 6, 2018
@adbridge
Copy link
Contributor

Cellular only came in for 5.8 it should have been fairly obvious therefore that this couldn't be backported to 5.7....

@mbed-ci
Copy link

mbed-ci commented Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants