-
Notifications
You must be signed in to change notification settings - Fork 3k
Unittests fixed #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unittests fixed #6268
Conversation
|
@jarvte, @kjbracey-arm Can you review this |
Can you update your commit msg and describe the fix (the line here in quote is actually what can be there). A commit msg like "Cellular tests: fix socket errors" and paragraph above would describe a bit more if needed. |
|
@0xc0170 Good suggestion Martin, this is now fixed |
|
/morph build |
Build : SUCCESSBuild number : 1335 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 992 |
Test : SUCCESSBuild number : 1119 |
|
I like trivial changes. |
|
Cellular only came in for 5.8 it should have been fairly obvious therefore that this couldn't be backported to 5.7.... |
Exporter Build : FAILUREBuild number : 1078 |
Description
nsapi_socket_t errors fixed in unittests
No code changes done, so should be trivial merge
Pull request type