-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove mbed 2 builds from Travis #6114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/morph mbed2-build |
💯 Can we get mbed2 build report back results (public access) ? will mbed build trigger also this job? will test /morph build |
Build : SUCCESSBuild number : 1155 Triggering tests/morph test |
Test : SUCCESSBuild number : 960 |
Exporter Build : FAILUREBuild number : 829 |
|
/morph export-build |
Exporter Build : FAILUREBuild number : 834 |
|
/morph export-build |
|
I review the test results. If this goes in, Test logs should be available same as regular morph CI does @studavekar Please review |
Exporter Build : SUCCESSBuild number : 848 |
|
@0xc0170 yes will have a link pointed to public results, have to take a look at example we are not building. |
|
test the public log link in status |
|
We have a public link to results in status http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/mbed2-release/6114/ |
|
@studavekar, are we going to put links in all the morph statuses? |
currently, we point to internal matirx bit pretty to look at :). It would be a trivial change to point to log location. If its useful to have the public there instead can do it. |
|
@0xc0170 I was looking at the scripts does it make sense to use build_travis.py directly? we would have identical results as current Travis job. |
This is nice (the job provides hook with results), if as @geky mentioned we can do for others as well, then we do not need to post a comment each time. If job fails and the link is to the public log, we will need to document (or provide internal link reference there somewhere) how to get to the CI log for review in case of failures (in situations like public logs are not published because of earlier CI stage failures or similar).
|
|
@0xc0170 I strongly think that we need a way to track a job that fails multiple times. I've lost count as to how many times I've wanted to look back at an older issue for the exact failure details, only to be greeted by an error page saying the logs were no longer available. Though for the short term, I'm fine with leaving it as a nice-to-have for sometime in the (hopefully) near future. |
|
@geky @studavekar Looking at this PR again, it looks like the Jenkins functionality is already in and the feedback question was us bikeshedding over the PR. Aside for the rebase that is now needed, is there anything else that needs to be done either in Jenkins or elsewhere before we migrate the mbed2 builds from TravisCI to Jenkins? |
|
@cmonr, #6114 (comment) I assume we are ok to run build_travis.py? an update should be statues/comment can we be taken offline? |
|
Sorry about the delay, should be good to go |
|
/morph build |
Build : FAILUREBuild number : 1442 |
|
/morph build |
Build : SUCCESSBuild number : 1457 Triggering tests/morph test |
|
Test was stopped to prioritize 5.7.7 mbed2 compilation. |
Exporter Build : SUCCESSBuild number : 1097 |
Test : FAILUREBuild number : 1227 |
|
CI issue: NRF52 flash cache test Restarting. |
Test : FAILUREBuild number : 1234 |
@cmonr should it be more of NRF52 issue failing the test? We should either fix the test or take it out. Re-triggering CI till it passes is not a solution. |
Test : SUCCESSBuild number : 1236 |
@studavekar got mbed 2 builds running on the Jenkins CI! Now it is much faster (~3 min as opposed to >30 min). There should now be an mbed-ci-mbed2-build job on all PRs.
I've removed the mbed 2 builds from Travis now. @0xc0170, if you can can you double check that the mbed-ci-mbed2-build output is correct?
cc @0xc0170, @theotherjimmy, @studavekar