K64F lp ticker driver - calculation bug fix. #6055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta calculation from lp_ticker_set_interrupt() function: delta_us = timestamp > now_us ? timestamp - now_us : (uint32_t)((uint64_t)timestamp + 0xFFFFFFFF - now_us); Lets assume that timestam == now_us. Expected delta value should be 0 and in this current version is 0xFFFFFFFF. The following condition: timestamp > now_us should have the following form: timestamp >= now_us Additionally modified us ticker driver to provide the same logic.
Contributor
|
@ARMmbed/team-nxp Please review |
Contributor
|
/morph build |
Build : SUCCESSBuild number : 1112 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 791 |
Contributor
Author
|
Can we run morph test here again - looks like previous one was canceled. |
Contributor
|
/morph test |
Test : SUCCESSBuild number : 935 |
0xc0170
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue with interrupt scheduling has been found while working on PR #6052.
Delta calculation from lp_ticker_set_interrupt() function:
mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/api/lp_ticker.c
Line 138 in 04f0f2b
Lets assume that
timestam==now_us.Expected delta value should be
0and in this current version is0xFFFFFFFF.The following condition:
timestamp > now_usshould have the following form:
timestamp >= now_usAdditionally modified us ticker driver to provide the same logic.
Status
READY
Migrations
NO