Skip to content

Fix bug allowing SPI::abort_transfer to incorrectly unlock deep sleep mode #5722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from Jan 11, 2018
Merged

Fix bug allowing SPI::abort_transfer to incorrectly unlock deep sleep mode #5722

merged 1 commit into from Jan 11, 2018

Conversation

@ghost
Copy link

@ghost ghost commented Dec 18, 2017

Description

Fix bug allowing SPI::abort_transfer to incorrectly unlock deep sleep mode

  • Add flag to SPI class to track if the SPI instance has locked deep sleep mode.
  • Wrap call to sleep_manager_lock_deep_sleep to only be called if SPI instance
    hasn't already locked deep sleep.
  • Wrap call to sleep_manager_unlock_deep_sleep to only be called if SPI has
    currently locked deep sleep mode.

Status

READY

0xc0170
0xc0170 approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume intention for lock/unclock deepsleep is protected by external means (SPI class is thread safe, thus deep sleep locking is already within already thread safe blocks in the implementation - _deep_sleep_locked is then protected). correct?

@adbridge
Copy link
Contributor

adbridge commented Jan 2, 2018

@c1728p9 @SenRamakri could you please review this?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2018

@scartmell-arm Can you please rebase to get travis fix please?

Fix bug allowing SPI::abort_transfer to incorrectly unlock deep sleep…
c267087 
… mode

- Add flag to SPI class to track if the SPI instance has locked deep sleep mode.
- Wrap call to sleep_manager_lock_deep_sleep to only be called if SPI instance
  hasn't already locked deep sleep.
- Wrap call to sleep_manager_unlock_deep_sleep to only be called if SPI has
  currently locked deep sleep mode.
@ghost
Copy link
Author

ghost commented Jan 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

Build : SUCCESS

Build number : 820
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5722/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

Exporter Build : SUCCESS

Build number : 472
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5722/

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

Test : SUCCESS

Build number : 660
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5722/660

@cmonr cmonr merged commit f14ddd1 into ARMmbed:master Jan 11, 2018
@0xc0170 0xc0170 mentioned this pull request Jan 12, 2018
Closed
@ghost ghost deleted the bug-spi-abort-deep-sleep branch December 5, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c1728p9 c1728p9 Awaiting requested review from c1728p9

@SenRamakri SenRamakri Awaiting requested review from SenRamakri

Assignees

No one assigned

Labels

release-version: 5.7.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adbridge @0xc0170 @mbed-ci @cmonr @theotherjimmy