Replace vendor specific register usage in stm32f4_emac.c with basic register #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…checking link status
Contributor
|
Looks good to me, the tests are passing on NUCLEO_F429ZG. |
Contributor
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 857 All builds and test passed! |
0xc0170
added
ready for merge
release-version: 5.1.5
and removed
needs: CI
ready for merge
labels
jeromecoutant
added a commit
to jeromecoutant/mbed
that referenced
this pull request
Sep 19, 2016
adbridge
pushed a commit
that referenced
this pull request
Sep 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of link state changes in stm32f4_emac.c seems to be vendor specific since it uses PHY registers above 16. To be more vendor independent we suggest to use the common registers to poll the link status. This is required to get ethernet on the C029 board to work.
What do you think?
@LMESTM
@bcostm
Status
Needs review. This has been locally verified to work with the C029 board but not with any ST-boards.