Adding retries to the NIST test. #2404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Did you only indent 2 spaces? Other than that the logic looks good 👍 |
Contributor
Author
|
@geky Good catch! I'll fix that :) Edit: Fixed! |
A UDP request to the NIST servers can fail to return data due to UDP packet loss. Since packets are not guaranteed with UDP, this is a valid failure and should not be treated as a test failure. The test should retry the request in this case. This commit adds those retries.
bridadan
force-pushed
the
retry-nist-udp-test
branch
from
dd51fa6 to
114efcf
Compare
Contributor
Author
|
/morph echo |
|
I recieved your comment! Here's what you wrote!
|
Contributor
Author
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
Contributor
Author
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 630 All builds and test passed! |
Contributor
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A UDP request to the NIST servers can fail to return data due to UDP
packet loss. Since packets are not guaranteed with UDP, this is a valid
failure and should not be treated as a test failure. The test should retry
the request in this case. This commit adds those retries.
This test sometimes fails in CI even when the actual PR can't cause the test to fail (#2393 is an example of this). This should help cut down on false failures.