Skip to content

Conversation

@svastm
Copy link
Contributor

@svastm svastm commented Aug 3, 2016

On STM32F0 and STM32F1, the channel selection of PWM, ADC and DAC are hard-coded (harder than in PeripheralPin.c). To be more consistent with other families, this PR move the channel selection to PeripheralPin.c by using the macro STM_PIN_DATA_EX.

svastm added 2 commits August 3, 2016 10:47
To be more consistant with ST targets, this commit change analog and pwm
channel definitions to PeripheralPins.c
To be more consistant with ST targets, this commit change analog and pwm
channel definitions to PeripheralPins.c
@screamerbg
Copy link
Contributor

@svastm this would need wider testing across Nucleo F0-F1. Happy to provide some test results?

@svastm
Copy link
Contributor Author

svastm commented Aug 4, 2016

I can't provide a test report because I did it with an oscilloscope. What I tested was the periphs, I did not try all the pins of all the targets.

With NUCLEO_F072RB and NUCLEO_F103RB, I was able to use PWM and AnalogIn (and AnalogOut on F0) correctly:

  • PWM on at least two different channels:
    • Init/generate.
  • ADC on at least two different channels:
    • Switch to 100% when plug to 3V3.
    • Switch to 0% when plug to GND.
  • DAC on the both channels:
    • Generate a sinus.

We need a check of all the pins ? or/and some no-reg tests over the boards ?

@bcostm
Copy link
Contributor

bcostm commented Aug 8, 2016

I don't think it is necessary to recheck all the pins again. I had a look in all modifications and LGTM.
Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 11, 2016

LGTM

@0xc0170 0xc0170 merged commit a79afc2 into ARMmbed:master Aug 11, 2016
@svastm svastm deleted the clean_pwm_analog branch August 16, 2016 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants