[NUCLEO_xxx] Fix us_ticker and analog_out issues when -O3/-Otime options are used #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue when the hal is compiled with -O3 -Otime
Contributor
There was a problem hiding this comment.
hello, can you explain why there are lines commented out without any comment in this commit?
Contributor
|
I talked with bcostm: the PA_5 is the second DAC channel on this device but unfortunately there is also the LED on this pin. He has kept it in the code as a reference for future boards, without this constraint. In the future, we probably want to keep this code under conditional compilation, depending on the target board. I am going to accept the pull request, we will improve the code in a second step. |
emilmont
added a commit
that referenced
this pull request
Feb 18, 2014
[NUCLEO_xxx] Fix us_ticker and analog_out issues when -O3/-Otime options are used
yossi2le
pushed a commit
to yossi2le/mbed-os
that referenced
this pull request
Mar 27, 2019
* Updated to Mbed OS 5.11.5 * Enabled powercut test for armcc
pan-
added a commit
to pan-/mbed
that referenced
this pull request
May 29, 2020
Updating mbed-os to mbed-os-5.9.6
ccli8
pushed a commit
to ccli8/mbed-os
that referenced
this pull request
Aug 13, 2024
* Add HALs to MbedCE * HALs for i3c like an option * Update stm32h5xx.h because of UTF-8 check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.