Skip to content

add the possibility to customize the delimiter of the ATHandler in AT… #15273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 10, 2022
Merged

add the possibility to customize the delimiter of the ATHandler in AT… #15273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
337b811
add the possibility to customize the delimiter of the ATHandler in AT…
Apr 20, 2022
d720db5
modify AT_CellularDevice_stub to pass test with the new feature
Tobi15 Apr 21, 2022
73f2dd6
modify method signatures to pass astyle tests
Tobi15 May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connectivity/cellular/include/cellular/framework/AT/AT_CellularDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class AT_CellularDevice : public CellularDevice {
};

public:
AT_CellularDevice(FileHandle *fh);
AT_CellularDevice(FileHandle *fh, char *delim = "\r");
virtual ~AT_CellularDevice();

virtual nsapi_error_t clear();
Expand Down
4 changes: 2 additions & 2 deletions connectivity/cellular/source/framework/AT/AT_CellularDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ using namespace std::chrono_literals;
#define DEFAULT_AT_TIMEOUT 1s // at default timeout
const int MAX_SIM_RESPONSE_LENGTH = 16;

AT_CellularDevice::AT_CellularDevice(FileHandle *fh) :
AT_CellularDevice::AT_CellularDevice(FileHandle *fh, char *delim):
CellularDevice(),
_at(fh, _queue, DEFAULT_AT_TIMEOUT, "\r"),
_at(fh, _queue, DEFAULT_AT_TIMEOUT, delim),
#if MBED_CONF_CELLULAR_USE_SMS
_sms(0),
#endif // MBED_CONF_CELLULAR_USE_SMS
Expand Down
4 changes: 2 additions & 2 deletions connectivity/cellular/tests/UNITTESTS/doubles/AT_CellularDevice_stub.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ bool AT_CellularDevice_stub::pin_needed = false;
bool AT_CellularDevice_stub::supported_bool = false;
int AT_CellularDevice_stub::max_sock_value = 1;

AT_CellularDevice::AT_CellularDevice(FileHandle *fh) :
AT_CellularDevice::AT_CellularDevice(FileHandle *fh, char *delim) :
CellularDevice(),
_at(fh, _queue, get_property(AT_CellularDevice::PROPERTY_AT_SEND_DELAY), "\r"),
_at(fh, _queue, get_property(AT_CellularDevice::PROPERTY_AT_SEND_DELAY), delim),
#if MBED_CONF_CELLULAR_USE_SMS
_sms(0),
#endif // MBED_CONF_CELLULAR_USE_SMS
Expand Down