lorawan: Fix Join Request retransmission timing (Interop test) - increase default value of downlink-preamble-length #15228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On interop test 1.2.2.4, Join Request retransmission is expected to be 6 s + worst case air transmission. This delay is to accommodate for JoinAccept through RX2. Increasing the downlink-preamble-length caused the rx_timeout of RX2 window to be increased by ~320ms (on RX2 window, symbol length is about 32 ms). Adding this change, increase the change of getting test 1.2.2.4 to succeed (test 1.2.2.4 is subset of test 1.2.2).
zul00
changed the title
|
Below is the screenshot from one of the succeed test: Below is the screenshot of the test log details: |
ciarmcom
added
the
release-type: patch
|
@zul00, thank you for your changes. |
0xc0170
approved these changes
Feb 16, 2022
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mergify
bot
removed
ready for merge
component: connectivity
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #15226
On interop test 1.2.2.4, Join Request retransmission is expected to be 6 s + worst case air transmission. This delay is to accommodate for JoinAccept through RX2.
Increasing the downlink-preamble-length caused the rx_timeout of RX2 window to be increased by ~320ms (on RX2 window, symbol length is about 32 ms).
Adding this change, increase the change of getting test 1.2.2.4 to succeed (test 1.2.2.4 is subset of test 1.2.2).
Impact of changes
The retransmission of Join Request will be delayed by 500 ms. This modification improve the chance of succeeding Interop Test 1.2.2.
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@hasnainvirk, as you were the original maintainer of it, can you give your opinion on it?