Skip to content

lorawan: Fix Join Request retransmission timing (Interop test) #15227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2022
Merged

lorawan: Fix Join Request retransmission timing (Interop test) #15227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion connectivity/lorawan/source/LoRaWANStack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,10 @@ void LoRaWANStack::process_reception_timeout(bool is_timeout)
_loramac.on_radio_rx_timeout(is_timeout);

if (slot == RX_SLOT_WIN_2 && !_loramac.nwk_joined()) {
state_controller(DEVICE_STATE_JOINING);
const int ret = _queue->call_in(
500, this, &LoRaWANStack::state_controller, DEVICE_STATE_JOINING);
MBED_ASSERT(ret != 0);
Copy link
Contributor

@0xc0170 0xc0170 Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lot of errors in this stack are reported just via tr_error. Should this be the same?
or just use error() instead of assert in this case

Copy link
Contributor Author

@zul00 zul00 Feb 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other locations, failure from EventQueue::call which indicates failure in allocating the event, would be handled by assertion. for example:

mbed-os/connectivity/lorawan/source/LoRaWANStack.cpp

Lines 514 to 516 in 61f8374

const int ret = _queue->call(this, &LoRaWANStack::process_transmission);
MBED_ASSERT(ret != 0);
(void)ret;

So I am following the same pattern.

(void)ret;
return;
}

Expand Down