Skip to content

Conversation

@jeromecoutant
Copy link
Collaborator

Summary of changes

Goal is to remove wrong console warning:

[Warning] @,: Compiler version mismatch: Have 10.3.1; expected version >= 9.0.0 and < 10.0.0

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 22, 2021
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

DIAGNOSTIC_PATTERN = re.compile('((?P<file>[^:]+):(?P<line>\d+):)(?P<col>\d+):? (?P<severity>warning|[eE]rror|fatal error): (?P<message>.+)')

GCC_RANGE = (LooseVersion("9.0.0"), LooseVersion("10.0.0"))
GCC_RANGE = (LooseVersion("9.0.0"), LooseVersion("11.0.0"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first should be also fixed to 10 (previously it was set to >9, <10, it should be now >10,<11

@0xc0170 0xc0170 requested a review from saheerb November 22, 2021 10:47
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2021

@saheerb Please review. I believe this was missed during the latest update to bump this to v10

@mergify mergify bot dismissed 0xc0170’s stale review November 22, 2021 10:49

Pull request has been modified.

@saheerb
Copy link
Contributor

saheerb commented Nov 22, 2021

The change looks alright but breaks the CI. I think this/similar change was considered before and dropped later because of CI breakage. Tools team might remember.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2021

I initially assumed this was missed as I could not remember details so I reached out for help.

We did not update the warning because of the online tools sharing the same code. We are not planning to update the online tools as they are frozen (it's quite a risk to update it at the moment, avoiding breakages).
We need to leave this as it is and close this pull request unfortunately.

@0xc0170 0xc0170 closed this Nov 22, 2021
@mergify mergify bot removed needs: review component: tools release-type: patch Indentifies a PR as containing just a patch labels Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants