Skip to content

CLI2: copy mapfile for diff statistics #15117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 14, 2021
Merged

CLI2: copy mapfile for diff statistics #15117

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
70b2193
copy map file to .old before creating new one
JojoS62 Sep 27, 2021
cfa8865
update cmake_minimum_required to 3.21.0
JojoS62 Sep 27, 2021
3d22c88
Merge branch 'fix-memmap-diff'
JojoS62 Sep 27, 2021
d4062f5
update README for new CMake version
JojoS62 Sep 27, 2021
5ae8e0e
replace file(copy by cmake -E copy
JojoS62 Oct 5, 2021
750247c
Revert "update cmake_minimum_required to 3.21.0"
JojoS62 Oct 5, 2021
bf677ae
Revert "Merge branch 'fix-memmap-diff'"
JojoS62 Oct 5, 2021
15a17dc
Revert "update README for new CMake version"
JojoS62 Oct 5, 2021
883fab4
update comment on custom command
JojoS62 Oct 5, 2021
7352660
remove comment
JojoS62 Oct 13, 2021
2b7b973
remove comment for renaming mapfile
JojoS62 Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tools/cmake/mbed_set_post_build.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ function(mbed_generate_map_file target)
COMMAND ${Python3_EXECUTABLE} ${mbed-os_SOURCE_DIR}/tools/memap.py -t ${MBED_TOOLCHAIN} ${CMAKE_CURRENT_BINARY_DIR}/${target}${CMAKE_EXECUTABLE_SUFFIX}.map
WORKING_DIRECTORY
${CMAKE_CURRENT_BINARY_DIR}
COMMENT
"Displaying memory map for ${target}"
)
endfunction()

Expand Down Expand Up @@ -87,6 +85,18 @@ function(mbed_set_post_build target)
# The mapfile name includes the top-level target name and the
# executable suffix for all toolchains as CMake hardcodes the name of the
# diagnostic output file for some toolchains.

# copy mapfile .map to .map.old for ram/rom statistics diff in memap.py
if(EXISTS ${CMAKE_CURRENT_BINARY_DIR}/${target}${CMAKE_EXECUTABLE_SUFFIX}.map)
add_custom_command(
TARGET
${target}
PRE_BUILD
COMMAND
${CMAKE_COMMAND} -E rename "${CMAKE_CURRENT_BINARY_DIR}/${target}${CMAKE_EXECUTABLE_SUFFIX}.map" "${CMAKE_CURRENT_BINARY_DIR}/${target}${CMAKE_EXECUTABLE_SUFFIX}.map.old"
)
endif()

mbed_configure_memory_map(${target} "${CMAKE_CURRENT_BINARY_DIR}/${target}${CMAKE_EXECUTABLE_SUFFIX}.map")
mbed_validate_application_profile(${target})
mbed_generate_bin_hex(${target})
Expand Down