Driver: USB: STM32L1: Managing internal pullups for usb enumeration #14990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds internal pullup on DP line for usb enumeration in nucleo_l152re platform. This platform as such does not have usb connector (device). This has been tested with example in https://github.com/ARMmbed/ mbed-os/blob/master/drivers/usb/include/usb/USBMouse.h#L58-L76 and mbed_app.json file "target_overrides": { "*": { "platform.stdio-baud-rate": 115200, "platform.all-stats-enabled": true, "mbed-trace.enable": "0" }, "NUCLEO_L152RE": { "target.device_has_add": ["USBDEVICE"] } } } Signed-off-by: Krishna Mohan Dani <[email protected]>
Member
|
@ikmdani, thank you for your changes. |
Contributor
Author
|
@jeromecoutant @fpistm for your review. |
0xc0170
approved these changes
Aug 11, 2021
fpistm
approved these changes
Aug 11, 2021
Member
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
Contributor
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mergify
bot
added
release version missing
|
This PR does not contain release version label after merging. |
Collaborator
|
@0xc0170 6.14.0 label is missing I think ? |
0xc0170
added
release-type: patch
mbedmain
removed
the
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds internal pullup on DP line for usb enumeration
in nucleo_l152re platform. This platform as such does not have
usb connector (device).
This has been tested with example in https://github.com/ARMmbed/
mbed-os/blob/master/drivers/usb/include/usb/USBMouse.h#L58-L76
and mbed_app.json file
"target_overrides": {
"*": {
"platform.stdio-baud-rate": 115200,
"platform.all-stats-enabled": true,
"mbed-trace.enable": "0"
},
"NUCLEO_L152RE": {
"target.device_has_add": ["USBDEVICE"]
}
}
}
Signed-off-by: Krishna Mohan Dani [email protected]
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers