Use standalone greentea-client #14803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@Patater, thank you for your changes. |
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
24 tasks
LDong-Arm
previously requested changes
Jun 23, 2021
I suppose CLI2 as CL1 doesn't use cmake ? |
Patater
force-pushed
the
fetchcontent-greentea
branch
from
529fc80 to
a44c05b
Compare
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
Patater
force-pushed
the
fetchcontent-greentea
branch
from
a44c05b to
6a6bbe0
Compare
|
Rebased on latest |
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
Any external libraries we depend on can be added from the "extern" folder.
Patater
force-pushed
the
fetchcontent-greentea
branch
from
fed2848 to
00fc196
Compare
|
Rebased on latest |
Patater
force-pushed
the
fetchcontent-greentea
branch
from
00fc196 to
a6dba39
Compare
Use FetchContent to obtain greentea-client at version XXX.
For CMake or Mbed CLI 2, use the standalone greentea-client.
When using an exported or installed version of greentea, it's necessary to use the greentea namespace.
Set MBED_TEST_MODE with INTERFACE. Use INTERFACE because mbed-os is an
interface target, and we can only set INTERFACE properties on interface
targets. This helps avoid the following error when building an
application.
CMake Error at mbed-os/CMakeLists.txt:96 (target_compile_definitions):
target_compile_definitions may only set INTERFACE properties on INTERFACE
targets
Patater
force-pushed
the
fetchcontent-greentea
branch
from
a6dba39 to
ef07746
Compare
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jul 8, 2021
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Use standalone greentea-client (from https://github.com/ARMmbed/greentea-client) for Mbed CLI 2. Make a new
externfolder to hold a CMakeLists.txt for fetching external dependencies like greentea-client. Use CMake'sFetchContent()to fetch greentea-client.Impact of changes
None
Migration actions required
None
Documentation
externfolder wherever we have folder structure documentationPull request type
Test results
Reviewers