Skip to content

Conversation

@jeromecoutant
Copy link
Collaborator

Summary of changes

2 propositions in both us_ticker and lp_ticker tests:

  • there was an issue with a potential u32/u64 mismatch
  • I added an optional CHECK_TICKER_OPTIM define. Goal is make a build failure if ticker optim defines are not present

@kjbracey-arm

There is no impact in the current tests, this is just helping customer to port targets.

Impact of changes

none

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


(1000000 * LP/US_TICKER_PERIOD_DEN) > U32
This will make build failure if ticker optim defines are not present
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 15, 2021
@ciarmcom ciarmcom requested a review from a team April 15, 2021 16:30
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 16, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants