BLE: Fix start scan command not returning error if parameters haven't been set

[paul-szczepanek-arm]

Summary of changes

Cordio doesn't return errors codes which can lead to a problem where start scan fails silently because parameters haven't been set. This additional check makes sure that we don't change scanning state if we know that start scan command will fail (due to unset params). This will return an error to the user if the params haven't been set first.

Impact of changes

Migration actions required

Documentation

none

---

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[ciarmcom]

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️

[jeromecoutant]

Hi

Note that since this patch, BLE can not compile any more with IAR...
I know IAR is no more required for mbed-os, but if someone has a solution, I think it could be good to apply?
Thx

[Error] GapImpl.h@995,17: [Pe321]: data member initializer is not allowed
[DEBUG] Output:       bool _scan_parameters_set : 1 = false;
[DEBUG] Output:                                     ^

[jeromecoutant]

With ARM, this makes a warning:

[Warning] GapImpl.h@995,35: default member initializer for bit-field is a C++20 extension [-Wc++20-extensions]

@0xc0170

[pan-]

Thanks for reporting it.

@paul-szczepanek-arm Can you look into this ? The issue seems to be the direct initialization of the _scan_parameters_set member.

[paul-szczepanek-arm]

Sure, I'll make a PR shortly.

[paul-szczepanek-arm]

#14603