Skip to content

Conversation

@LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Mar 8, 2021

Summary of changes

Due to a bug in TF-M v1.2, Musca S1 is not fully initialised by the secure binary. This leads to malfunctioning and performance issues around timer, IRQ, sleep, etc. Thanks to our Greentea test suites, we've caught this in our nightly CI - the failing suites are:

  • hal-tests-tests-mbed_hal-common_tickers
  • hal-tests-tests-mbed_hal-sleep
  • hal-tests-tests-mbed_hal-sleep_manager
  • platform-tests-tests-mbed_platform-wait_ns
  • rtos-tests-tests-mbed_rtos-event_flags

The fix is ARMmbed/trusted-firmware-m#15 which will also be upstreamed to the trusted-firmware-m project. This PR brings in the secure binaries containing the fix.

Impact of changes

Timings, IRQ and sleep related issues on Musca S1 are now fixed. All Greentea tests pass.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon


@LDong-Arm LDong-Arm changed the title Updated secure binaries with platform init fix for ARM_MUSCA_S1 Update secure binaries with platform init fix for ARM_MUSCA_S1 Mar 8, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 8, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Mar 8, 2021

@LDong-Arm, thank you for your changes.
@evedon @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Mar 8, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 8, 2021

cI started

@mergify mergify bot added needs: CI and removed needs: review labels Mar 8, 2021
@mbed-ci
Copy link

mbed-ci commented Mar 8, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM
jenkins-ci/mbed-os-ci_build-example-GCC_ARM
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️

@LDong-Arm
Copy link
Contributor Author

We have a CI issue today. We can wait for ARMmbed/trusted-firmware-m#15 to get in first, after which I'll need to update VERSION.txt in this PR anyway.

evedon
evedon previously approved these changes Mar 9, 2021
@mergify mergify bot dismissed stale reviews from 0xc0170 and evedon March 9, 2021 10:23

Pull request has been modified.

@LDong-Arm
Copy link
Contributor Author

Rebased and added VERSION.txt

@LDong-Arm LDong-Arm requested review from 0xc0170 and evedon March 9, 2021 10:23
@mbed-ci
Copy link

mbed-ci commented Mar 9, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_tfm-integration ✔️

@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants