Skip to content

Conversation

@LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Mar 1, 2021

Summary of changes

Scripts in tools/targets are related to target support - they are technically not core parts of the old tools. To integrate the latest TF-M, we need to be able to update the post binary hook for Musca targets in that path.

#14354 depends on this.

Impact of changes

Modifications are allowed in tools/targets.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Patater @ARMmbed/mbed-b-tools


Scripts in tools/targets are related to target support - they are
technically not core parts of the old tools. To integrate the latest
TF-M, we need to be able to update the post binary hook for Musca
targets in that path.
@ciarmcom
Copy link
Member

ciarmcom commented Mar 1, 2021

@LDong-Arm, thank you for your changes.
@Patater @ARMmbed/mbed-os-maintainers please review.

@Patater
Copy link
Contributor

Patater commented Mar 1, 2021

We prefer to keep this area frozen, as changes to these scripts may have an impact on the online compiler or IDE. We've been approving exceptions on a case-by-case basis. Musca, which isn't supported in the online compiler, generally receives such exceptions and we merge even with Travis CI failing.

@0xc0170 can confirm we sometimes merge changes even with Travis CI failing the frozen tools check.

Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tools/targets is referenced from the online tools, so we can't remove this from the frozen check.

@LDong-Arm
Copy link
Contributor Author

We prefer to keep this area frozen, as changes to these scripts may have an impact on the online compiler or IDE. We've been approving exceptions on a case-by-case basis. Musca, which isn't supported in the online compiler, generally receives such exceptions and we merge even with Travis CI failing.

This makes sense. But the failing of "Frozen tools check" prevents the other Travis tests from being run: https://github.com/ARMmbed/mbed-os/pull/14354/checks?check_run_id=1980968740
Those tests did pass for all TF-M v1.2 related PRs that didn't touch targets/tools, so are we okay if the final PR (merging to master) doesn't have a full Travis run?

@Patater
Copy link
Contributor

Patater commented Mar 1, 2021

so are we okay if the final PR (merging to master) doesn't have a full Travis run?

We've in the past been able to test the rest of Travis by removing the frozen files from the PR, then putting it back in before merge. That's probably not practical for the TF-M PR though.

Is it possible to have Travis CI do a full run even if frozen tools fails? I would welcome a PR to make that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants