Skip to content

Update stm32xx_emac driver traces #14341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

Update stm32xx_emac driver traces #14341

merged 1 commit into from
Feb 25, 2021

Conversation

@artokin
Copy link
Contributor

@artokin artokin commented Feb 24, 2021 •
edited by 0xc0170
Loading

Summary of changes

  • Make low_level_input trace optional as it is generated for every incoming packet and thus increasing log file size. Detailed trace can be be enabled by enabling the new macro STM32xx_DEEP_TRACE.
2021-02-23T16:21:34.599Z | INFO | <--|D0| b'[DBG ][STE1]: low_level_input len 90'
2021-02-23T16:21:34.599Z | INFO | <--|D0| b'[DBG ][STE1]: low_level_input no frame'
  • Shorten traces during the driver initialisation to avoid problems with driver startup when device is started with soft reset.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikaleppanen , @mikter , @JarkkoPaso , @juhhei01

Update stm32xx_emac traces
e4e2f79 
- Make packet trace optional, can be enabled by enabling macro
  STM32xx_DEEP_TRACE
- Shorten traces during driver initialisation to avoid problems with
  driver startup when soft reset is used.
@ciarmcom
Copy link
Member

ciarmcom commented Feb 24, 2021

@artokin, thank you for your changes.
@mikaleppanen @juhhei01 @mikter @JarkkoPaso @ARMmbed/team-st-mcd @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 24, 2021

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2021

It looks like we got internal issue. I restarted, if it fails again, will investigate further.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 25, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 25, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 25, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 63eeb93 into ARMmbed:master Feb 25, 2021
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Feb 25, 2021
@mergify
Copy link

mergify bot commented Feb 25, 2021

This PR does not contain release version label after merging.

@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release version missing When PR does not contain release version, bot should label it and we fix it afterwards labels Feb 25, 2021
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikter mikter mikter approved these changes

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@juhhei01 juhhei01 Awaiting requested review from juhhei01

+2 more reviewers

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component: connectivity devices: st release-version: 6.9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@artokin @ciarmcom @0xc0170 @mbed-ci @JarkkoPaso @mikter @jeromecoutant @mikaleppanen @mbedmain