Skip to content

Conversation

@hugueskamba
Copy link
Collaborator

Summary of changes

The Mbed TLS Greentea tests can now be built with CMake.

Building the sanity test requires the following:

  1. From the Mbed OS root directory, run cp TESTs/configs/experimental.json /path/to/mbed-os-example-tls/hashing/mbed_app.json
  2. From mbed-os-example-tls/hashing, run mbedtools configure -t ARM -m K64F && cp -r .mbedbuild /path/to/mbed-os/connectivity/mbedtls/tests/TESTS/mbedtls/sanity/
  3. From mbed-os/connectivity/mbedtls/tests/TESTS/mbedtls/sanity/, run touch mbed-os.lib && mkdir cmake_build && cd cmake_build && cmake .. -G Ninja && cmake --build .

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@hugueskamba hugueskamba force-pushed the hk_cmake_greentea_mbedtls branch from 74198f5 to 317333f Compare January 20, 2021 14:39
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 20, 2021
@ciarmcom ciarmcom requested review from a team January 20, 2021 15:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-security @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2021

Building the sanity test requires the following:

@hugueskamba Is it worth having in docs? readme.md where the tests are ?

@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 24, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @0xc0170, @urutva, @rajkan01, @ARMmbed/mbed-os-maintainers, @ARMmbed/mbed-os-security, please complete review of the changes to move the PR forward. Thank you for your contributions.

@hugueskamba hugueskamba removed the stale Stale Pull Request label Jan 25, 2021
The Mbed TLS Greentea tests can now be built with CMake.
@hugueskamba hugueskamba force-pushed the hk_cmake_greentea_mbedtls branch from 317333f to 9a1c24e Compare January 25, 2021 10:48
@hugueskamba
Copy link
Collaborator Author

Building the sanity test requires the following:

@hugueskamba Is it worth having in docs? readme.md where the tests are ?

This force-push adds information about the need to use specific configuration files when building some Greentea tests.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the previous tools also have these json config required to build tests so no change there.

@mergify mergify bot added needs: CI and removed needs: review labels Jan 25, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jan 27, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 27, 2021

I'll start CI with other PRs today

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 2, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 276e835 into ARMmbed:master Feb 2, 2021
@mergify mergify bot removed the ready for merge label Feb 2, 2021
@hugueskamba hugueskamba deleted the hk_cmake_greentea_mbedtls branch February 2, 2021 14:30
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants