Skip to content

CMake: Simplify BLE library inclusion #13948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2020
Merged

CMake: Simplify BLE library inclusion #13948

merged 1 commit into from
Nov 25, 2020

Conversation

@rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Nov 23, 2020 •
edited by hugueskamba
Loading

Summary of changes

  • Security manager which is part of mbed-ble library uses some feature from wsf of the mbed-ble-cordio library so added target_link_library to link the BLE library with cordio stack lib.

Impact of changes

None.

Migration actions required

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Manual testing:
Successfully build the BLE_Advertising examples by only specified mbed-ble in CMakeLists.txt file of target_link_libararies section, which intern brought mbed-ble-cordio and mbed-ble-blue_nrg dependent libraries.

Reviewers

@0xc0170 @hugueskamba

@rajkan01
CMake: target_link_library the BLE with CORDIO stack
a964453 
- Security manager uses some feature from wsf which is part of the mbed-ble-cordio library so added target_link_library to link the BLE library to cordio stack lib.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 23, 2020
@ciarmcom ciarmcom requested review from a team, 0xc0170 and hugueskamba November 23, 2020 16:30
@ciarmcom
Copy link
Member

ciarmcom commented Nov 23, 2020

@rajkan01, thank you for your changes.
@hugueskamba @0xc0170 @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@rajkan01 rajkan01 mentioned this pull request Nov 23, 2020
Merged
@mergify mergify bot added needs: CI and removed needs: review labels Nov 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2020 •
edited
Loading

We just need mbed-ble in the apps with this fix?

CI started

@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 24, 2020

We just need mbed-ble in the apps with this fix?

CI started

@0xc0170 Yes, apps only need to include mbed-ble

pan-
pan- approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajkan01 BLE always depends on the Cordio host stack.

@mbed-ci
Copy link

mbed-ci commented Nov 24, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ❌

@mergify mergify bot added needs: work and removed needs: CI labels Nov 24, 2020
@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 24, 2020

@0xc0170 Could you restart the cloud client test as it failed with timeout error
[2020-11-24T17:07:23.188Z] [2020-11-24T17:07:23.188Z] timeout_error_msg = "Didn't find client registered in 300 s"

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@rajkan01
Copy link
Contributor Author

rajkan01 commented Nov 25, 2020

@0xc0170 This PR CI have passed, could you merge

@0xc0170 0xc0170 merged commit 483db06 into ARMmbed:master Nov 25, 2020
@mergify mergify bot removed the ready for merge label Nov 25, 2020
@mbedmain mbedmain added Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees

No one assigned

Labels

release-version: 6.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rajkan01 @ciarmcom @0xc0170 @mbed-ci @pan- @hugueskamba @mbedmain