Skip to content

Conversation

@ccli8
Copy link
Contributor

@ccli8 ccli8 commented Oct 16, 2020

Summary of changes

This PR upgrades BSP to v3.00.001 to support MP chip.

Impact of changes

NuMaker-M2354 Ver 1.0 (test chip) gets unsupported. This doesn't do big impact because it is internal only. NuMaker-M2354 Ver 1.1 (MP chip) will be the official one with this upgrade.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 4 commits October 15, 2020 11:58
In test chip, byte-read (LDRB) last byte of flash in non-secure world always gets 0xFF.
This is got around by overriding flash_read(...). Now, the override can remove in MP chip.
1.  Change to support MP chip. Original M2355 BSP is for test chip.
2.  UART0, used for USB VCOM, has change in clock enable bit. So chip/board version and BSP version must match.
3.  Remove TF-M legacy code.
1.  Upgrade to BSP v3.00.001 for MP chip
2.  Enable fault handler dump message
@ciarmcom ciarmcom requested a review from a team October 16, 2020 06:30
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 19, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Oct 21, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 21, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2020

I'll restart the CI (client test failure)

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 4f69795 into ARMmbed:mbed-os-5.15 Oct 30, 2020
@mergify mergify bot removed the ready for merge label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants