BLE: Add function to signal privacy initialization. #13680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pan-, thank you for your changes. |
paul-szczepanek-arm
approved these changes
Sep 29, 2020
| } | ||
|
|
||
| if (_privacy_initialization_pending && | ||
| _address_registry.get_resolvable_private_address() != address_t{} && |
There was a problem hiding this comment.
Yes it is if privacy is enabled then disabled or if the security manager has been enabled ~50ms before the privacy.
There was a problem hiding this comment.
how would the on_private_address_generated be called then?
There was a problem hiding this comment.
It is called but it has no effect since privacy is not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers