Skip to content

Conversation

@MartinBielik
Copy link

In case of slave transfer we dont want the slave to perform stop signal.

Signed-off-by: Bielik [email protected]

Summary of changes

If multiple bytes are send from slave to master, slave is wrongly performing stop signal what brakes communication for 11ms because bus is still active. Slave shouldn't do any Start or Stop signal

Impact of changes

Migration actions required

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


In case of slave transfer we dont want the slave to perform stop signal.

Signed-off-by: Bielik <[email protected]>
@ciarmcom ciarmcom requested a review from a team September 24, 2020 09:30
@ciarmcom
Copy link
Member

@MartinBielik, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team September 24, 2020 15:47
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me but would like someone from @ARMmbed/team-nxp to confirm as it's their driver

@mergify mergify bot added needs: CI and removed needs: review labels Sep 29, 2020
@maclobdell
Copy link
Contributor

@mmahadevan108 can you review?

Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

CI started

@0xc0170 0xc0170 requested a review from andypowers September 30, 2020 08:26
@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 49bd70b into ARMmbed:mbed-os-5.15 Sep 30, 2020
@mergify mergify bot removed the ready for merge label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants