Skip to content

BLE Fix read and write callbacks for descriptors not firing if characteristic is not readable or writable #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2020
Merged

BLE Fix read and write callbacks for descriptors not firing if characteristic is not readable or writable #13293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioGattServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ ble_error_t GattServer::insert_descriptor(
#endif // BLE_FEATURE_SECURITY
}

if (properties & READ_PROPERTY && !(attribute_it->settings & ATTS_SET_CCC)) {
if (!(attribute_it->settings & ATTS_SET_CCC)) {
Copy link
Member Author

@paul-szczepanek-arm paul-szczepanek-arm Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the real condition to check is descriptor->isReadAllowed() which is already checked above

attribute_it->settings |= ATTS_SET_READ_CBACK;
}
}
Expand Down Expand Up @@ -543,7 +543,7 @@ ble_error_t GattServer::insert_descriptor(
#endif // BLE_FEATURE_SECURITY
}

if (properties & WRITABLE_PROPERTIES && !(attribute_it->settings & ATTS_SET_CCC)) {
if (!(attribute_it->settings & ATTS_SET_CCC)) {
Copy link
Member Author

@paul-szczepanek-arm paul-szczepanek-arm Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

attribute_it->settings |= ATTS_SET_WRITE_CBACK;
}
}
Expand Down