Skip to content

Reduce LED use in automatic CI tests #13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Reduce LED use in automatic CI tests #13213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cc72e7
Remove LED2 in integration tests
jeromecoutant Jul 1, 2020
eac3c95
LED1 and LED2 removed from tests-mbed_drivers-ticker
jeromecoutant Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions TESTS/integration/fs-single/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,9 @@ using namespace utest::v1;

#if !defined(MBED_CONF_APP_NO_LED)
DigitalOut led1(LED1);
DigitalOut led2(LED2);
void led_thread()
{
led1 = !led1;
led2 = !led1;
}
#endif

Expand Down
2 changes: 0 additions & 2 deletions TESTS/integration/fs-threaded/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ using namespace utest::v1;

#if !defined(MBED_CONF_APP_NO_LED)
DigitalOut led1(LED1);
DigitalOut led2(LED2);
void led_thread()
{
led1 = !led1;
led2 = !led1;
}
#endif

Expand Down
2 changes: 0 additions & 2 deletions TESTS/integration/net-single/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ using namespace utest::v1;

#if !defined(MBED_CONF_APP_NO_LED)
DigitalOut led1(LED1);
DigitalOut led2(LED2);
void led_thread()
{
led1 = !led1;
led2 = !led1;
}
#endif

Expand Down
2 changes: 0 additions & 2 deletions TESTS/integration/net-threaded/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ using namespace utest::v1;

#if !defined(MBED_CONF_APP_NO_LED)
DigitalOut led1(LED1);
DigitalOut led2(LED2);
void led_thread()
{
led1 = !led1;
led2 = !led1;
}
#endif

Expand Down
2 changes: 0 additions & 2 deletions TESTS/integration/stress-net-fs/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,9 @@ using namespace utest::v1;

#if !defined(MBED_CONF_APP_NO_LED)
DigitalOut led1(LED1);
DigitalOut led2(LED2);
void led_thread()
{
led1 = !led1;
led2 = !led1;
}
#endif

Expand Down
33 changes: 0 additions & 33 deletions TESTS/mbed_drivers/ticker/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,42 +39,17 @@ static const int total_ticks = 10;
volatile uint32_t ticker_callback_flag;
volatile uint32_t multi_counter;

DigitalOut led1(LED1);
DigitalOut led2(LED2);

Timer gtimer;
volatile int ticker_count = 0;


void switch_led1_state(void)
{
// blink 3 times per second
if ((callback_trigger_count % 333) == 0) {
led1 = !led1;
}
}

void switch_led2_state(void)
{
// blink 3 times per second
// make led2 blink at the same callback_trigger_count value as led1
if (((callback_trigger_count - 1) % 333) == 0) {
led2 = !led2;
}
}

void ticker_callback_1(void)
{
++callback_trigger_count;
switch_led1_state();
}

void ticker_callback_2(void)
{
++callback_trigger_count;
if (LED2 != NC) {
switch_led2_state();
}
}


Expand Down Expand Up @@ -112,10 +87,6 @@ void test_case_1x_ticker()
int expected_key = 1;
Ticker ticker;

led1 = 1;
if (LED2 != NC) {
led2 = 1;
}
callback_trigger_count = 0;

greentea_send_kv("timing_drift_check_start", 0);
Expand Down Expand Up @@ -155,10 +126,6 @@ void test_case_2x_ticker()
int expected_key = 1;
Ticker ticker1, ticker2;

led1 = 0;
if (LED2 != NC) {
led2 = 1;
}
callback_trigger_count = 0;

ticker1.attach_us(ticker_callback_1, 2 * ONE_MILLI_SEC);
Expand Down