Skip to content

BLE: Upgrade cordio Link Layer to 20.05r #13103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 1, 2020
Merged

BLE: Upgrade cordio Link Layer to 20.05r #13103

merged 21 commits into from
Jul 1, 2020

Conversation

@paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Jun 12, 2020

Summary of changes

Update cordio LL stack to 20.05

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-

@mergify mergify bot added the needs: work label Jun 12, 2020
@mergify
Copy link

mergify bot commented Jun 12, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@paul-szczepanek-arm paul-szczepanek-arm changed the title Upgrade cordio 20 05 ll BLE: Upgrade cordio 20 05 ll Jun 12, 2020
@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE: Upgrade cordio 20 05 ll BLE: Upgrade cordio Link Layer to 20.05r Jun 12, 2020
@ciarmcom
Copy link
Member

ciarmcom commented Jun 12, 2020

@paul-szczepanek-arm, thank you for your changes.
@pan- @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team and pan- June 12, 2020 09:00
0xc0170
0xc0170 previously approved these changes Jun 15, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Jun 15, 2020
@mergify mergify bot dismissed 0xc0170’s stale review June 15, 2020 19:13

Pull request has been modified.

0xc0170
0xc0170 previously approved these changes Jun 16, 2020
View reviewed changes
@mergify mergify bot dismissed 0xc0170’s stale review June 17, 2020 11:11

Pull request has been modified.

0xc0170
0xc0170 previously approved these changes Jun 17, 2020
View reviewed changes
@mergify mergify bot dismissed 0xc0170’s stale review June 17, 2020 12:26

Pull request has been modified.

pan-
pan- reviewed Jun 22, 2020
View reviewed changes
...s/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_CORDIO/TARGET_NRF5x/NRFCordioHCIDriver.cpp

// For some reason, the mbed target uses this (TIMER0_IRQHandler_v) vector name instead of the "standard" TIMER0_IRQHandler one
NVIC_SetVector(TIMER0_IRQn, (uint32_t)TIMER0_IRQHandler);
NVIC_SetVector(TIMER2_IRQn, (uint32_t)TIMER2_IRQHandler);
Copy link
Member

@pan- pan- Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comment. This is the case for 2 IRQs and a note for future porters might be useful.

pan-
pan- previously approved these changes Jun 24, 2020
View reviewed changes
@mergify
Copy link

mergify bot commented Jun 24, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot added needs: work and removed needs: CI labels Jun 24, 2020
@mergify mergify bot dismissed pan-’s stale review June 24, 2020 10:10

Pull request has been modified.

@paul-szczepanek-arm
Copy link
Member Author

paul-szczepanek-arm commented Jun 24, 2020

ready to merge

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2020

@pan- Merge whenever you can

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

pan-
pan- approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pan- pan- merged commit 8197b48 into ARMmbed:feature-cordio-update-20-05 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pan- pan- pan- approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees

No one assigned

Labels

needs: review release-version: feature branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paul-szczepanek-arm @ciarmcom @0xc0170 @mbed-ci @pan-