Skip to content

enable storage tests on baremetal #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

enable storage tests on baremetal #12843

merged 1 commit into from
Apr 22, 2020

Conversation

@ithinuel
Copy link
Member

@ithinuel ithinuel commented Apr 21, 2020

Summary of changes

This enables the storage greentea tests in baremetal mode.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon

@ciarmcom ciarmcom requested review from a team and evedon April 21, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 21, 2020

@ithinuel, thank you for your changes.
@evedon @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 22, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

CI started

VeijoPesonen
VeijoPesonen approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mbed-ci
Copy link

mbed-ci commented Apr 22, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 422b194 into ARMmbed:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon Awaiting requested review from evedon

+1 more reviewer

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-beta-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ithinuel @ciarmcom @0xc0170 @mbed-ci @VeijoPesonen