Skip to content

Override c_lib to small for all targets #12833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

Override c_lib to small for all targets #12833

merged 1 commit into from
Apr 22, 2020

Conversation

@evedon
Copy link
Contributor

@evedon evedon commented Apr 20, 2020 •
edited
Loading

Summary of changes

Override "c_lib" to "small" for all targets when testing with the bare metal profile.
With the new tools functionality added in #12691, if the small C library is not supported for a given toolchain then the standard C library will be used (if it is supported).

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba

@ciarmcom ciarmcom requested review from a team and hugueskamba April 20, 2020 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 20, 2020

@evedon, thank you for your changes.
@hugueskamba @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but please add a reason for this override to the commit msg itself

@evedon
Override c_lib to small for all targets.
8be00a1 
Small C libraries should be used with the bare metal profile
to save memory.
@evedon evedon force-pushed the ed-baremetal-json branch from e7fc0b9 to 8be00a1 Compare April 20, 2020 17:06
@mergify mergify bot dismissed 0xc0170’s stale review April 20, 2020 17:07

Pull request has been modified.

@evedon
Copy link
Contributor Author

evedon commented Apr 20, 2020

Change LGTM but please add a reason for this override to the commit msg itself

Done

hugueskamba
hugueskamba approved these changes Apr 21, 2020
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added needs: CI and removed needs: work labels Apr 22, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 22, 2020

ci started

@mbed-ci
Copy link

mbed-ci commented Apr 22, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 5e76548 into ARMmbed:master Apr 22, 2020
@mergify mergify bot removed the ready for merge label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees

No one assigned

Labels

release-version: 6.0.0-beta-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@evedon @ciarmcom @0xc0170 @mbed-ci @hugueskamba