Skip to content

Cellular: Fix BG96 offloaded DNS query for new API #12830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2020
Merged

Cellular: Fix BG96 offloaded DNS query for new API #12830

merged 1 commit into from
Apr 21, 2020

Conversation

@kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Apr 20, 2020

Summary of changes

Fixed following issues in BG96 offloaded DNS:

  • Fixed mbed-os 6 API change for asynchronous DNS callback. Return value is no longer
    an error value but in success case the amount of DNS records
  • Asynchronous request returns request ID instead of NSAPI_ERROR_OK. BG96 supports only
    one asynchronouse DNS query at the time, so ID 1 is used.
  • BG96 does not support multi-ip DNS responses, so disabled multi-ip tests

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-wan

Cellular: Fix BG96 offloaded DNS query for new API
fe98dbe 
Fixed following issues in BG96 offloaded DNS:
- Fixed mbed-os 6 API change for asynchronous DNS callback. Return value is no longer
  an error value but in success case the amount of DNS records
- Asynchronous request returns request ID instead of NSAPI_ERROR_OK. BG96 supports only
  one asynchronouse DNS query at the time, so ID 1 is used.
- BG96 does not support multi-ip DNS responses, so disabled multi-ip tests
@ciarmcom ciarmcom requested review from a team April 20, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 20, 2020

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Apr 20, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2020

Test run: FAILED

Summary: 1 of 6 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Apr 21, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit f468c9b into ARMmbed:master Apr 21, 2020
@mergify mergify bot removed the ready for merge label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-beta-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kivaisan @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila