Skip to content

EFM32G11: Add RGB LEDs to PinNames.h #12692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

EFM32G11: Add RGB LEDs to PinNames.h #12692

merged 1 commit into from
Mar 26, 2020

Conversation

@petroborys
Copy link
Contributor

@petroborys petroborys commented Mar 24, 2020

Summary of changes

Added RGB LEDs to PinNames.h for EFM32G11. This will make it easy to use the features EFM32G11's LEDs. Tested on the EFM32GG11_STK3701.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[х] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team March 24, 2020 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 24, 2020

@petroborys, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Added RGB LEDs to PinNames.h for EFM32G11 EFM32G11: Add RGB LEDs to PinNames.h Mar 25, 2020
@0xc0170 0xc0170 requested a review from a team March 25, 2020 08:10
0xc0170
0xc0170 reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names (LEDxRGB) are coming from some examples or somewhere else ? Just curious if these are known names for this board.

@petroborys
Copy link
Contributor Author

petroborys commented Mar 25, 2020 •
edited
Loading

These names (LEDxRGB) are coming from some examples or somewhere else ? Just curious if these are known names for this board.

From SLSTK3701A Giant Gecko GG11 Starter Kit User's Guide - p.15 (6.1 Push Buttons and RGB LEDs)
https://www.silabs.com/products/development-tools/mcu/32-bit/efm32-giant-gecko-gg11-starter-kit

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@stevew817
Copy link
Contributor

stevew817 commented Mar 25, 2020

Thanks @petroborys !

@0xc0170 0xc0170 merged commit f011ccb into ARMmbed:master Mar 26, 2020
@mergify mergify bot removed the ready for merge label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@stevew817 stevew817 stevew817 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.0.0-beta-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petroborys @ciarmcom @0xc0170 @mbed-ci @stevew817