Skip to content

Add UBLOX_onboard_modem_api for power up UBLOX_C027. #12610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

Add UBLOX_onboard_modem_api for power up UBLOX_C027. #12610

merged 1 commit into from
Apr 1, 2020

Conversation

@mudassar-ublox
Copy link
Contributor

@mudassar-ublox mudassar-ublox commented Mar 10, 2020 •
edited
Loading

Summary of changes

Added UBLOX_onboard_modem_api for powering up modem. As onboard_modem_api is removed and functionality of onboard_modem_api is added in ONBOARD_UBLOX_PPP. For cellular api's this class, ONBOARD_UBLOX_PPP, is inherited from UBLOX_PPP, which ultimately initialize cellular ATHandler.

Problem occurs, when I use ONBOARD_UBLOX_PPP class in my own libraries to power up modem
then it initialize cellular ATHandler and failed to initialize my ATCmdParser.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mudassar-ublox mudassar-ublox changed the title Added UBLOX_modem_api for power up UBLOX_C027. Added UBLOX_onboard_modem_api for power up UBLOX_C027. Mar 10, 2020
@ciarmcom ciarmcom requested review from a team and maclobdell March 10, 2020 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Mar 10, 2020

@mudassar-ublox, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team March 17, 2020 09:25
0xc0170
0xc0170 previously requested changes Mar 17, 2020
View reviewed changes
@0xc0170 0xc0170 changed the title Added UBLOX_onboard_modem_api for power up UBLOX_C027. Add UBLOX_onboard_modem_api for power up UBLOX_C027. Mar 19, 2020
@mergify mergify bot dismissed 0xc0170’s stale review March 30, 2020 12:03

Pull request has been modified.

@mudassar-ublox
Copy link
Contributor Author

mudassar-ublox commented Mar 30, 2020

Updated and added SPDX id. Please review now.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit d308da1 into ARMmbed:master Apr 1, 2020
@mergify mergify bot removed the ready for merge label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@adbridge adbridge adbridge approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees

No one assigned

Labels

release-version: 6.0.0-beta-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mudassar-ublox @ciarmcom @0xc0170 @mbed-ci @adbridge